Conversation
krbarnes
commented
Aug 14, 2018
| cellUpdater(cell.view, state) | ||
| } | ||
|
|
||
| @inline(never) |
Contributor
Author
There was a problem hiding this comment.
This was a previous attempt to fix the same crash. It did nothing.
g-Off
approved these changes
Aug 14, 2018
raulriera
reviewed
Aug 14, 2018
| // Compares two arrays of TableSections and produces the operations | ||
| // required to go from one to the other | ||
| public struct TableSectionChangeSet { | ||
| public class TableSectionChangeSet { |
dannbeau
approved these changes
Aug 14, 2018
dannbeau
approved these changes
Aug 14, 2018
raulriera
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
TableSectionChangeSetfrom a struct to class.Since Swift 4.1 we have seen many crashes in
HostCell.isEqual. None of the crashes make sense, but the crash is a SEGV_ACCERR which implies that multiple threads are accessing the same memory.Changing the change set from struct to class and eliminating the mutating functions maybe makes these crashes go away.